On Thu, Apr 28, 2011 at 10:18:01AM +0900, Simon Horman wrote: > On Thu, Apr 28, 2011 at 10:06:38AM +0900, Magnus Damm wrote: > > On Thu, Apr 28, 2011 at 7:14 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > > > I believe that on the sh73a0 and so far only the sh73a0 > > > denom needs to be doubled. > > > > Uhm, I don't think this patch is specific to any SoC type. It may of > > course be used on sh73a0 to adjust the denom value, but setting the > > I2C bus speed is something that can be used on any SoC. So I'd say > > that this is a fairly generic feature. > > I'm just saying that that I've observed the value being doubled for sh73a0. > The general rule of thumb is that whatever unusual behaviour is observed in the latest CPU we will see become the standard for future ones. Abstracting the denom value seems reasonable as a cautionary measure, and it does do the NORMAL_SPEED as a default fallback so there is no adverse impact for normalized platforms. This really should be going in to include/linux/i2c/ or so though, no need to dump these tiny stubs in to include/linux/ directly. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
