On 03/23/2011 11:50 AM, Tomoya MORINAGA wrote: > Hi Jiri, > > It looks OK. > > Signed-off-by: Tomoya MORINAGA <tomoya-linux@xxxxxxxxxxxxxxx> Hi, will somebody take it or should I resubmit? > Thanks, > ----------------------------------------- > Tomoya MORINAGA > OKI SEMICONDUCTOR CO., LTD. > >> -----Original Message----- >> From: linux-kernel-owner@xxxxxxxxxxxxxxx >> [mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On Behalf Of Jiri Slaby >> Sent: Wednesday, March 23, 2011 5:50 PM >> To: jirislaby@xxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx; Jiri Slaby; Jean Delvare; >> linux-i2c@xxxxxxxxxxxxxxx >> Subject: [PATCH 5/7] I2C: eg20t, remove unused variable >> >> drivers/i2c/busses/i2c-eg20t.c:684:2: warning: Value stored >> to 'msglen' is never read msglen = (pmsg->len) - (subaddrlen + 1); >> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> >> Cc: Jean Delvare <khali@xxxxxxxxxxxx> >> Cc: linux-i2c@xxxxxxxxxxxxxxx >> --- >> drivers/i2c/busses/i2c-eg20t.c | 8 -------- >> 1 files changed, 0 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-eg20t.c >> b/drivers/i2c/busses/i2c-eg20t.c index 878a120..ea73252 100644 >> --- a/drivers/i2c/busses/i2c-eg20t.c >> +++ b/drivers/i2c/busses/i2c-eg20t.c >> @@ -651,8 +651,6 @@ static s32 pch_i2c_xfer(struct >> i2c_adapter *i2c_adap, >> struct i2c_msg *pmsg; >> u32 i = 0; >> u32 status; >> - u32 msglen; >> - u32 subaddrlen; >> s32 ret; >> >> struct i2c_algo_pch_data *adap = i2c_adap->algo_data; >> @@ -676,12 +674,6 @@ static s32 pch_i2c_xfer(struct >> i2c_adapter *i2c_adap, >> status = pmsg->flags; >> pch_dbg(adap, >> "After invoking I2C_MODE_SEL :flag= 0x%x\n", status); >> - /* calculate sub address length and message length */ >> - /* these are applicable only for buffer mode */ >> - subaddrlen = pmsg->buf[0]; >> - /* calculate actual message length excluding >> - * the sub address fields */ >> - msglen = (pmsg->len) - (subaddrlen + 1); >> if (status & (I2C_M_RD)) { >> pch_dbg(adap, "invoking pch_i2c_readbytes\n"); >> ret = pch_i2c_readbytes(i2c_adap, pmsg, (i + 1 == num), >> -- >> 1.7.4.1 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-kernel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > -- js -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
