On Fri, Mar 25, 2011 at 08:12:06AM +0530, Tushar Behera wrote: > Hi Ben, > > On 24 March 2011 16:17, Ben Dooks <ben-i2c@xxxxxxxxx> wrote: > > On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote: > >> On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want > >> to enable support for I2C. But the I2C controller is selected only > >> if I2C_S3C2410 is defined. > >> > >> This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected. > > > > No. Do not do this, just having the device on the board does not mean > > you want it forced into the kernel. A user may want to build it as a > > module or not build it at-all. > > > Thanks for your comments. Sorry, default should be fine... it's select that is something that shouldn't be done. I'll test and apply tomorrow. That'll teach me to go reviewing stuff before the first proper coffee of the morning. -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
