Dear Dave Jones, On 9 March 2011 06:02, Dave Jones <davej@xxxxxxxxxx> wrote: > On Tue, Mar 08, 2011 at 03:56:56PM +0900, Minkyu Kang wrote: > > > +static DEVICE_ATTR(switch, S_IRUGO | S_IWUGO, > > + fsa9480_show_manualsw, fsa9480_set_manualsw); > > This probably shouldn't be world writable if it's writing to hardware. > It can be used in user space. Thanks Minkyu Kang -- from. prom. www.promsoft.net -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html