[PATCH] i2c-eg20t: fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



drivers/i2c/busses/i2c-eg20t.c:477:5: warning: symbol 'pch_i2c_readbytes' was not declared. Should it be static?
drivers/i2c/busses/i2c-eg20t.c:804:42: warning: Using plain integer as NULL pointer

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>


--- a/drivers/i2c/busses/i2c-eg20t.c	2011-02-20 13:24:43.445948555 -0800
+++ b/drivers/i2c/busses/i2c-eg20t.c	2011-02-20 13:25:14.915448908 -0800
@@ -474,8 +474,8 @@ static void pch_i2c_sendnack(struct i2c_
  * @last:	specifies whether last message or not.
  * @first:	specifies whether first message or not.
  */
-s32 pch_i2c_readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
-		  u32 last, u32 first)
+static s32 pch_i2c_readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
+			     u32 last, u32 first)
 {
 	struct i2c_algo_pch_data *adap = i2c_adap->algo_data;
 
@@ -801,7 +801,7 @@ static void __devexit pch_i2c_remove(str
 
 	if (adap_info->pch_data.pch_base_address) {
 		pci_iounmap(pdev, adap_info->pch_data.pch_base_address);
-		adap_info->pch_data.pch_base_address = 0;
+		adap_info->pch_data.pch_base_address = NULL;
 	}
 
 	pci_set_drvdata(pdev, NULL);

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux