On Sat, Feb 19, 2011 at 01:57, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > Do we have any pressing need to convert AMBA stuff? I haven't heard any > reason yet to convert them to runtime PM - they don't even make any > runtime PM calls. > > Maybe Linus can comment on the PM stuff as he has SoCs with these in. > As my boards don't have any sensible PM support, I don't have any > visibility of what PM facilities would be required. The rationale for runtime power control is the same as that for 65500fa94aaeb3 "ARM: 6467/1: amba: optional PrimeCell core voltage switch". As compared to the regulator API which that patch is using, the runtime pm usage is more flexible (for example allowing certain power control APIs to be called from atomic context), provides callbacks for asynchronous turnoff with callbacks back to the driver to save/restore state (runtime_suspend()/runtime_resume()), and provides core support for things like "autosuspend" which allows delaying suspend until some time after last inactivity. Using runtime PM also allows use of the new device-level power domain support ("PM: Add support for device power domains", in -next) to easily implement SoC-specific handling. We need to first add bus support for this to allow drivers to use this API. It is possible to make the AMBA patch smaller and touch only the AMBA bus code by implementing support for the legacy bus-specific suspend/resume calls, and drivers can be later converted to pm-ops as needed. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html