On Wed, Feb 16, 2011 at 5:22 AM, Ben Dooks <ben-i2c@xxxxxxxxx> wrote:
> On Tue, Feb 15, 2011 at 10:13:58AM +0530, J, KEERTHY wrote:
>> On Tue, Feb 15, 2011 at 5:35 AM, Kevin Hilman <khilman@xxxxxx> wrote:
>> > Keerthy <j-keerthy@xxxxxx> writes:
>> >
>> >> From: Richard woodruff <r-woodruff2@xxxxxx>
>> >>
>> >> ProDB00017052 - ARDY interrupt reasserted after being cleared.
>> >
>> >> This errata caused intermittent i2c instabilty(1 error per 3 hours) on several
>> >> customer platforms. After applying the workaround the intermittent errors were
>> >> not seen. This is not captured in the usual errata documents.
>> >
>> > This (presumably internal) ProDB number above is meaningless in the
>> > public changelog. In lieu of a public erratum number, just summarize
>> > the erratum/instability seen, references to other relevant public
>> > errata (if any) would be useful too. IOW, "instability" isn't quite
>> > accurate enough. A more detailed description of the problem/instability
>> > is needed.
>> >
>>
>> Kevin,
>>
>> Yes the ProDB number is internal. I will remove it from the change log.
>> I will add a more detailed description of the problem.
>
> Leave it in a comment at the most, it might be useful, otherwise please
> respond to Kevin's review and then it'll be ready to merge.
>
Ben,
I will add a more detailed description.
--
Regards and Thanks,
Keerthy
>> --
>> Regards and Thanks,
>> Keerthy
>>
>>
>> > Thanks,
>> >
>> > Kevin
>> >
>> >>
>> >> The workaround is to have a double clear of ARDY status in
>> >> irq handler.
>> >>
>> >> Signed-off-by: Richard woodruff <r-woodruff2@xxxxxx>
>> >> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
>> >> ---
>> >> drivers/i2c/busses/i2c-omap.c | 3 ++-
>> >> 1 files changed, 2 insertions(+), 1 deletions(-)
>> >>
>> >> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>> >> index 445de08..9bcefae 100644
>> >> --- a/drivers/i2c/busses/i2c-omap.c
>> >> +++ b/drivers/i2c/busses/i2c-omap.c
>> >> @@ -851,7 +851,8 @@ complete:
>> >> OMAP_I2C_STAT_AL)) {
>> >> omap_i2c_ack_stat(dev, stat &
>> >> (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR |
>> >> - OMAP_I2C_STAT_XRDY | OMAP_I2C_STAT_XDR));
>> >> + OMAP_I2C_STAT_XRDY | OMAP_I2C_STAT_XDR |
>> >> + OMAP_I2C_STAT_ARDY));
>> >> omap_i2c_complete_cmd(dev, err);
>> >> return IRQ_HANDLED;
>> >> }
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/
>
> Large Hadron Colada: A large Pina Colada that makes the universe disappear.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
