Hi Guenter,
Wow, 6 patches :)
On Sun, 13 Feb 2011 12:17:21 -0800, Guenter Roeck wrote:
> The old method to provide the value mask has long since been deprecated,
> remove it.
> ---
> CHANGES | 1 +
> tools/i2cset.c | 12 ------------
> 2 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/CHANGES b/CHANGES
> index 5aee418..999ff26 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -4,6 +4,7 @@ i2c-tools CHANGES
> SVN
> i2c-dev.h: Make value arrays const for block write functions
> i2cset: Add support for SMBus and I2C block writes
> + Remove obsolete means to specify value mask
>
> 3.0.3 (2010-12-12)
> Makefile: Let the environment set CC and CFLAGS
> diff --git a/tools/i2cset.c b/tools/i2cset.c
> index 392262b..8856d71 100644
> --- a/tools/i2cset.c
> +++ b/tools/i2cset.c
> @@ -265,18 +265,6 @@ int main(int argc, char *argv[])
> pec = argv[flags+5][1] == 'p';
> }
>
> - /* Old method to provide the value mask, deprecated and no longer
> - documented but still supported for compatibility */
> - if (argc > flags + 6) {
> - if (maskp) {
> - fprintf(stderr, "Error: Data value mask provided twice!\n");
> - help();
> - }
> - fprintf(stderr, "Warning: Using deprecated way to set the data value mask!\n");
> - fprintf(stderr, " Please switch to using -m.\n");
> - maskp = argv[flags+6];
> - }
> -
> if (maskp) {
> vmask = strtol(maskp, &end, 0);
> if (*end || vmask == 0) {
This looks good, however I think the code can be cleaned up further by
getting rid of maskp. I introduced maskp [1] because the mask could be
at two different places on the command line, but now it is no longer
needed.
[1] http://www.lm-sensors.org/changeset/5390
Also, I see that we don't do range checks on the mask value. As you are
in the process to make command line parsing more strict, it would
probably be a good idea to add range changes on the mask value too.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
