On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein@xxxxxxxxxx wrote: > From: Rhyland Klein <rklein@xxxxxxxxxx> > > adding support for the ISL 29018 ambient light and proximity sensor. > > Addressed comments from reviews by Jonathan Cameron and Joe Perches > * Removed some excess dbg prints that only printed function name > * Renamed some properties to make them more descriptive > * Added a property to list available adc resolutions > * Defined arrays for resolutions/ranges as static const > * Change loops initialization to memset for extensibility. > * used sizeof() instead of ARRAY_SIZE() to be safer > * Added a property to list available adc ranges > > Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx> > Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> Too bad no one actually compiled this driver: CC [M] drivers/staging/iio/light/isl29018.o drivers/staging/iio/light/isl29018.c:420:8: error: âshow_prox_infrared_suppressionâ undeclared here (not in a function) drivers/staging/iio/light/isl29018.c:433:1: error: âiio_dev_attr_range_availableâ undeclared here (not in a function) drivers/staging/iio/light/isl29018.c:435:1: error: âiio_dev_attr_adc_resolution_availableâ undeclared here (not in a function) drivers/staging/iio/light/isl29018.c: In function âisl29018_chip_initâ: drivers/staging/iio/light/isl29018.c:451:6: warning: unused variable âiâ drivers/staging/iio/light/isl29018.c: At top level: drivers/staging/iio/light/isl29018.c:350:16: warning: âshow_prox_infrared_supressionâ defined but not used drivers/staging/iio/light/isl29018.c:416:1: warning: âiio_const_attr_range_availableâ defined but not used drivers/staging/iio/light/isl29018.c:417:1: warning: âiio_const_attr_adc_resolution_availableâ defined but not used make[2]: *** [drivers/staging/iio/light/isl29018.o] Error 1 make[1]: *** [drivers/staging/iio/light] Error 2 make: *** [_module_drivers/staging/iio] Error 2 Please fix this up before resending it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
