On Tue, Oct 05, 2010 at 04:19:18PM -0000, Alan Cox wrote: > +config KEYBOARD_TC35894XBG > + tristate "TC35894XBG I2C keypad support" This looks one of the TC3589x family of I/O expanders. For the TC35892, there's already a minimal MFD core in driver/mfd/tc35892.c, and a driver for the GPIO block based on that in drivers/gpio/tc35892-gpio.c. Comparing the registers map in this patch with the TC35892 datasheet, the parts look very similar, so would it be possible for you to make this driver use the TC35892 MFD core, so that multiple blocks can used simultaneously? There's no keypad driver for the series in mainline yet, but Sundar was readying one for the TC35893; I'll let him comment on how similar the keypad parts look, and what it would take to support the TC35894XBG and TC35893 keypads in one driver. Rabin -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html