RE: [PATCH v2] iio: light: Adding driver for ISL29018 ALS

[Rhyland Klein <rklein@xxxxxxxxxx>]

> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> Sent: Tuesday, October 05, 2010 2:35 PM
> To: Rhyland Klein
> Cc: jic23@xxxxxxxxx; Andrew Chew; olof@xxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> iio@xxxxxxxxxxxxxxx; Laxman Dewangan
> Subject: Re: [PATCH v2] iio: light: Adding driver for ISL29018 ALS
> 
> On Tue, 2010-10-05 at 14:19 -0700, rklein@xxxxxxxxxx wrote:
> > Adding support for the ISL 29018 ambient light and proximity sensor.
> 
> Trivial comments below.
> 
> > diff --git a/drivers/staging/iio/light/isl29018.c
> b/drivers/staging/iio/light/isl29018.c
> []
> > +static int isl29018_set_range(struct i2c_client *client, unsigned long
> range,
> > +		unsigned int *new_range)
> > +{
> > +	unsigned long supp_ranges[] = {1000, 4000, 16000, 64000};
> 
> static const

Will change.

> 
> > +static int isl29018_set_resolution(struct i2c_client *client,
> > +			unsigned long adcbit, unsigned int *conf_adc_bit)
> > +{
> > +	unsigned long supp_adcbit[] = {16, 12, 8, 4};
> 
> here too

This too.

> 
> > +static int isl29018_chip_init(struct i2c_client *client)
> > +{
> > +	struct isl29018_chip *chip = i2c_get_clientdata(client);
> > +	int status;
> > +	int i;
> > +	int new_adc_bit;
> > +	unsigned int new_range;
> > +
> > +	for (i = 0; i < ARRAY_SIZE(chip->reg_cache); i++)
> > +		chip->reg_cache[i] = 0;
> 
> memset?
> 

I could use memset, except this is only 4 registers = 32 bytes, so I don't think that is really worth it do you?

ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þ-œþ)íèjg¬±¨¶‰šŽŠÝjÿ¾«þG«é¸¢·¦j:+v‰¨Šwèm¶Ÿÿþø®w¥þŠà£¢·hšâÿ†Ù