... >> subtle change here... Out of intererst, why did the top level lis3_dev >> structure ever exist? (you can tell I haven't looked closely at this driver >> before!) Can remove_fs return an error? > > Remove fs returns always 0. > > There are couple of bigger changes which somebody should do to this > driver: > - Change static lis3_dev structure to a dynamically allocated one//generalize Definitely. > - Add proper error handling to the driver. Agreed, hopefully someone will step up and do it (good job for a starting out kernel dev perhaps?) -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
