Re: [PATCH] fix PCA waitforcompletion() return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 22, 2010 at 11:20:48AM +0200, Yegor Yefremov wrote:
> ret is still -1, if during the polling read_byte() returns at once
> with I2C_PCA_CON_SI set. So ret > 0 would lead *_waitforcompletion()
> to return 0, in spite of the proper behavior.
> 
> The routine was rewritten, so that ret has always a proper value,
> before returning.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> Reviewed-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

Great! Jean, I think this is .36-relevant. Do you plan another
pull-request (hmm, there is still my clientdata-patch ;))? Should
probably go to stable, too.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux