Re: [PATCH v3] i2c: davinci: Fix race when setting up for TX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> On 9/17/2010 6:09 AM, Sudhakar Rajashekhara wrote:
>>> I remember I had some issues on OMAP-L138 with this fix, that's when
>>> I reverted to configuring ICMDR before writing to DXR (Please see
>>> here: https://patchwork.kernel.org/patch/75262/). I checked the BIOS
>>> I2C driver code for OMAP-L138 and there also we are configuring MDR
>>> before accessing DXR.
> 
> Ah :/
> 
>>
>> and resetting the i2c upon a NAK interrupt (after the stop)
>> to clear the bad fifo data?
> 
> I can't really comment on how valid that would be and can't easily test it.
> 
> However preloading DXR does save one interrupt on transmit so the whole operation is faster and more efficient.
> 
> Maybe v1 of my patch, with locking, is the best option?
> 
> --
> Jon Povey

How about writing MDR twice? Once where Sudakar wants it, without the start bit.
And then where you want it with the start bit?


Troy
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux