Hi Rhyland, On Thu, 2 Sep 2010 10:29:46 -0700, rklein@xxxxxxxxxx wrote: > From: Rhyland Klein <rklein@xxxxxxxxxx> > > this driver depends on I2C and uses SMBUS for communication with the host. > > Addressed comments from reviews by Mark Brown and Jean Delvare. > * Cleaned up whitespace and alignment issues > * changed return codes to more appropriate values > * change Kconfig option name to be consistent with existing devices > * removed global struct and moved to device specific data > * changed printk to dev_dbg Looks much better. A few details could be ironed out: > > Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx> > --- > drivers/power/Kconfig | 7 + > drivers/power/Makefile | 1 + > drivers/power/bq20z75.c | 387 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 395 insertions(+), 0 deletions(-) > create mode 100644 drivers/power/bq20z75.c > > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 8e9ba17..53d9cbf 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > @@ -142,4 +142,11 @@ config CHARGER_PCF50633 > help > Say Y to include support for NXP PCF50633 Main Battery Charger. > > +config BATTERY_BQ20Z75 > + tristate "TI BQ20z75 gas gauge" > + depends on I2C > + help > + Say Y to include support for TI bq20z75 SBS-compliant Please leave the BQ in capitals for consistency. > + gas gauge and protection IC. > + > endif # POWER_SUPPLY > diff --git a/drivers/power/Makefile b/drivers/power/Makefile > index 0005080..cdc403d 100644 > --- a/drivers/power/Makefile > +++ b/drivers/power/Makefile > @@ -34,3 +34,4 @@ obj-$(CONFIG_BATTERY_DA9030) += da9030_battery.o > obj-$(CONFIG_BATTERY_MAX17040) += max17040_battery.o > obj-$(CONFIG_BATTERY_Z2) += z2_battery.o > obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o > +obj-$(CONFIG_BATTERY_BQ20Z75) += bq20z75.o Would be nice to move this entry right before CONFIG_BATTERY_BQ27x00. Same for Kconfig, BTW. > diff --git a/drivers/power/bq20z75.c b/drivers/power/bq20z75.c > new file mode 100644 > index 0000000..a7eeedf > --- /dev/null > +++ b/drivers/power/bq20z75.c > (...) > +static int bq20z75_get_property(struct power_supply *psy, > + enum power_supply_property psp, union power_supply_propval *val); You no longer need this forward declaration. Once these small details are fixed, feel free to add: Reviewed-by: Jean Delvare <khali@xxxxxxxxxxxx> -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
