Mark, have you had a chance to double check my changes based on the comments you made? Thanks, Rhyland -----Original Message----- From: Anton Vorontsov [mailto:cbouatmailru@xxxxxxxxx] Sent: Thursday, September 02, 2010 10:48 AM To: Rhyland Klein Cc: linux-i2c@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; olof@xxxxxxxxx; Andrew Chew; khali@xxxxxxxxxxxx; broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC On Thu, Sep 02, 2010 at 10:29:46AM -0700, rklein@xxxxxxxxxx wrote: > From: Rhyland Klein <rklein@xxxxxxxxxx> > > this driver depends on I2C and uses SMBUS for communication with the host. > > Addressed comments from reviews by Mark Brown and Jean Delvare. > * Cleaned up whitespace and alignment issues > * changed return codes to more appropriate values > * change Kconfig option name to be consistent with existing devices > * removed global struct and moved to device specific data > * changed printk to dev_dbg The driver looks good to me. But I'll wait a day or two for Jean's and Mark's Acked-by or Reviewed-by tags before applying, just to give them some credit for reviwing this driver. Thanks! -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 ��.n��������+%������w��{.n�����{��-��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
