Hi Samu,
few minor comments,
On Fri, Aug 27, 2010 at 5:24 PM, Samu Onkalo <samu.p.onkalo@xxxxxxxxx> wrote:
> +
> +struct ak8974_chip {
> + struct miscdevice miscdev;
> + struct mutex lock; /* Serialize access to chip */
> + struct mutex users_lock;
> + struct i2c_client *client;
> + struct regulator_bulk_data regs[2];
> + struct work_struct work;
> + wait_queue_head_t misc_wait;
> + loff_t offset;
> +
> + int max_range;
> + int users;
> +
> + const char *id;
> + u8 info[2];
> +
> + s16 x, y, z; /* Latest measurements */
> + s8 axis_x;
> + s8 axis_y;
> + s8 axis_z;
> + bool valid;
> +
> + char name[20];
> +};
This can be static ?
> +
> + ak8974_regulators_off(chip);
> +
[..]
> + if (err < 0) {
> + dev_err(&chip->client->dev, "Device registration failed\n");
> + goto fail3;
> + }
[..]
> + return 0;
> +fail4:
> + misc_deregister(&chip->miscdev);
> +fail3:
> + ak8974_regulators_off(chip);
in case of fail3, regulators get disabled twice. i think we will have
unbalanced calls to the supplies then.
> +
> +
> +#ifdef CONFIG_PM
> +static int ak8974_suspend(struct i2c_client *client, pm_message_t mesg)
> +{
> + struct ak8974_chip *chip = i2c_get_clientdata(client);
> + mutex_lock(&chip->users_lock);
> + if (chip->users > 0)
> + ak8974_enable(chip, AK8974_PWR_OFF);
> + mutex_unlock(&chip->users_lock);
> + return 0;
> +}
Can we disable the regulators here too?
Regards,
Sundar
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
