Hi Arnd, > If you pass IRQF_SHARED, you can register any number of handlers > for the same IRQ number using different dev pointers. I will modify like above. Thanks, Ohtake. ----- Original Message ----- From: "Arnd Bergmann" <arnd@xxxxxxxx> To: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx> Cc: "Jean Delvare (PC drivers, core)" <khali@xxxxxxxxxxxx>; "Ben Dooks (embedded platforms)" <ben-linux@xxxxxxxxx>; <linux-i2c@xxxxxxxxxxxxxxx>; "LKML" <linux-kernel@xxxxxxxxxxxxxxx>; <qi.wang@xxxxxxxxx>; "Wang, Yong Y" <yong.y.wang@xxxxxxxxx>; <joel.clark@xxxxxxxxx>; <andrew.chih.howe.khor@xxxxxxxxx> Sent: Tuesday, July 20, 2010 6:27 PM Subject: Re: [PATCH] I2C driver of Topcliff PCH > On Tuesday 20 July 2010, Masayuki Ohtake wrote: > > > > + > > > > + dev_dbg(&pdev->dev, > > > > + "i2c_add_adapter returns %d for channel-%d\n", ret, i); > > > > + pch_init(&adap_info->pch_data[i]); > > > > + dev_dbg(&pdev->dev, "pch_init invoked successfully\n"); > > > > + } > > > > + > > > > + ret = request_irq(pdev->irq, &pch_handler, IRQF_SHARED, > > > > + MODULE_NAME, adap_info); > > > > > > Similarly, you would create a new channel data structure for each channel here > > > and register it separately, and then request the interrupt with that > > > data structure as the info. > > > > With I2c multi-cahnnel IOH, IRQ number is in common. > > Thus, I think our PCH I2C driver can't be implemented like above. > > If you pass IRQF_SHARED, you can register any number of handlers > for the same IRQ number using different dev pointers. > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
