Nishanth Menon <nm@xxxxxx> writes: > very minor comments below: > On 04/28/2010 12:47 AM, G, Manjunath Kondaiah wrote: [...] >> struct omap_i2c_dev { >> struct device *dev; >> @@ -199,6 +201,7 @@ struct omap_i2c_dev { >> u16 bufstate; >> u16 syscstate; >> u16 westate; >> + u16 errata; > overall I'd prefer the term quirk over errata - quirk is more of a > standard linux term used accross network, usb and other drivers, will > allow the code to be a little more familiar with the upstream > maintainers/reviewers.. but i leave it to tony and others to comment > more.. maybe it is just me being an ass again ;) I prefer the term errata since it is also the term used by TI docs. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html