On Thursday 25 March 2010, Mark Brown wrote: > On Thu, Mar 25, 2010 at 09:57:20AM +0100, Jean Delvare wrote: > > > Mark, you contributed the initial runtime PM support for the i2c > > subsystem, I thought you would have comments on Rafael's > > reimplementation? > > Yeah, see below... > > > > drivers/i2c/i2c-core.c | 168 ++++++++++++++++++++++++++------------------- > > > include/linux/pm_runtime.h | 7 + > > > I am a little surprised to see changes to a generic header file here, > > how is the i2c subsystem so special that we have needs other subsystems > > did not? > > Very few subsystems actually support runtime PM thus far - I think it's > more the case that I2C is an early user than anything else. That's the case indeed. > > Apart from the above, the code looks sane to me, but then again I don't > > know a thing about power management. I'll keep this patch in my i2c > > tree, scheduled for merge in 2.6.35. If there are any updates, please > > send them over, either as a new patch or as incremental changes which I > > will merge myself. > > I'm in a similar position - the code looks fine except I'm not 100% sure > I follow all the possible ifdefs and I've never actually used hibernate > (s2disk isn't supported on ARM) but for what it's worth: > > Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Thanks! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
