Re: [PATCH] i2c-dev.c: remove unnecessary casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 9 Mar 2010 17:45:57 -0600, H Hartley Sweeten wrote:
> The private_data member of struct file is a void *, there is no need
> to cast it.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> 
> ---
> 
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index f4110aa..c507204 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -138,7 +138,7 @@ static ssize_t i2cdev_read (struct file *file, char __user *buf, size_t count,
>  	char *tmp;
>  	int ret;
>  
> -	struct i2c_client *client = (struct i2c_client *)file->private_data;
> +	struct i2c_client *client = file->private_data;
>  
>  	if (count > 8192)
>  		count = 8192;
> @@ -162,7 +162,7 @@ static ssize_t i2cdev_write (struct file *file, const char __user *buf, size_t c
>  {
>  	int ret;
>  	char *tmp;
> -	struct i2c_client *client = (struct i2c_client *)file->private_data;
> +	struct i2c_client *client = file->private_data;
>  
>  	if (count > 8192)
>  		count = 8192;
> @@ -369,7 +369,7 @@ static noinline int i2cdev_ioctl_smbus(struct i2c_client *client,
>  
>  static long i2cdev_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  {
> -	struct i2c_client *client = (struct i2c_client *)file->private_data;
> +	struct i2c_client *client = file->private_data;
>  	unsigned long funcs;
>  
>  	dev_dbg(&client->adapter->dev, "ioctl, cmd=0x%02x, arg=0x%02lx\n",

Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux