On Mon, Mar 08, 2010 at 08:50:08AM +0100, Jean Delvare wrote: > From: Jean Delvare <khali@xxxxxxxxxxxx> > Subject: at24: Fall back to byte or word reads if needed > > Increase the portability of the at24 driver by letting it read from > EEPROM chips connected to cheap SMBus controllers that support neither > raw I2C messages nor even I2C block reads. All SMBus controllers > should support either word reads or byte reads, so read support > becomes universal, much like with the legacy "eeprom" driver. > > Obviously, this only works with EEPROM chips up to AT24C16, that use > 8-bit offset addressing. 16-bit offset addressing is almost impossible > to support on SMBus controllers. > > I did not add universal support for writes, as I had no immediate need > for this, but it could be added later if needed (with the same > performance issue as byte and word reads have, of course.) > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > Cc: Konstantin Lazarev <klazarev@xxxxxxxxxxxxx> I wondered a bit if switch-case would make the code more readable instead of if-elseif-elseif-else. But definately no show-stopper. I don't have hardware to actually test the new functionality, other than that it appears good to me. Thanks! Reviewed-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
