On Tue, 16 Feb 2010 21:27:15 +0100, Wolfram Sang wrote: > On Tue, Feb 16, 2010 at 12:21:52PM +0100, Jean Delvare wrote: > > I like building with -Wshadow, it helps catch bugs or at least bad > > choices in variable names. > > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > Cc: Jonathan Cameron <jic23@xxxxxxxxx> > > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > --- > > Any objection? > > [After some searching] > > Do you know if -Wshadow has improved since this thread? > > http://kerneltrap.org/node/7434 Probably not. This is the reason why I enabled -Wshadow only in 2 selected subdirectories where I think it makes sense (low driver count) rather than the whole kernel (or even the whole i2c subsystem.) The fact that it spotted one (admittedly harmless) bug, and would have caught my confusing code in i2c-smbus too, make me confident that this is not too bad an idea. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
