On Mon, 15 Feb 2010 20:08:24 +0100, Rafael J. Wysocki wrote: > On Monday 15 February 2010, Mark Brown wrote: > > On Mon, Feb 15, 2010 at 07:14:09PM +0100, Jean Delvare wrote: > > > > > Applied, thanks. I am a little surprised to see that these functions > > > have nothing i2c-specific, so I am wondering why we have to duplicate > > > them in every bus type... Shouldn't the functions above be part of > > > drivers/base/power/runtime.c and exported so that all bus types that > > > want them can reuse them? > > In fact this is the first bus type that doesn't need anything specific in these > routines so fat. > > > I tend to agree - in fact I'd been a little surprised the default for > > buses that don't provide anything was to refuse to do runtime PM (though > > I can see the transition issues when a bus does want to go and do its > > own thing). > > > > My actual plan here was to implement this for a couple of buses and then > > present a patch factoring out the common code. > > That's a good approach IMO. OK, fine with me. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
