Re: [PATCH] mxc i2c: let time to generate stop bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 21, 2010 at 12:27:43PM +0100, Valentin Longchamp wrote:
> After generating the stop bit by changing MSTA from 1 to 0,
> the i2c_imx->stopped was immediatly set to 1. The second test
> on i2c_imx->stopped then is correct and the controller never
> waits if the bus is busy. This patch corrects this.
> 
> On mx31moboard, stop bit was not generated on single write transfers.
> This was kept unnoticed other transfers are made afterwards that
> help the write recipient to resynchronize.

"as other transfers"?

> Thanks to Philippe and Michael for the debugging.

Either full names, or maybe even Reported-by or Tested-by tags?

> Signed-off-by: Valentin Longchamp <valentin.longchamp@xxxxxxx>

Patch itself looks good to me:

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux