Re: [PATCH v2 0/3] i2c-designware: Allow mixed endianness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jean-Hugues Deschenes wrote:
This is the v2 version of the patch which adds support
for the i2c Designware controller when its endianness
differs from that of the cpu.

---
Changelog v1->v2
- rename i2c_dw_(read|write)l to dw_(read|write)l (Shinya Kuribayashi)
- rename dw_(read|write)l's addr argument to offset (Shinya Kuribayashi)
- replace (if constant == x) with (if x == constant) (Ben Dooks)
---


Signed-off-by: Jean-Hugues Deschenes <jean-hugues.deschenes@xxxxxxxxxxx>

All three patches look good, and work for my BE machines.

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@xxxxxxxxx>

---

diff --git a/drivers/i2c/busses/i2c-designware.c b/drivers/i2c/busses/i2c-designware.c
index 362dd9e..ce20fc8 100644
--- a/drivers/i2c/busses/i2c-designware.c
+++ b/drivers/i2c/busses/i2c-designware.c
@@ -778,6 +783,12 @@ static int __devinit dw_i2c_probe(struct platform_device *pdev)
			r = -ENODEV;
			goto err_iounmap;
		}
+
+		printk("### comp_type = 0x%08x\n", comp_type);
+		printk("### ___constant_swab32(0x44570140) = 0x%08x\n",
+			___constant_swab32(0x44570140));
+		printk("### swab = %d\n", dev->swab);
+
	}
	{
		u32 param1 = dw_readl(dev, DW_IC_COMP_PARAM_1);

[...]

i2c /dev entries driver
### comp_type = 0x44570140
### ___constant_swab32(0x44570140) = 0x40015744
### swab = 0
### comp_type = 0x44570140
### ___constant_swab32(0x44570140) = 0x40015744
### swab = 0
### comp_type = 0x44570140
### ___constant_swab32(0x44570140) = 0x40015744
### swab = 0

--
Shinya Kuribayashi
NEC Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux