Hi Cory, On Mon, Jan 18, 2010 at 01:23:25PM -0800, Cory Maccarrone wrote: > On Mon, Jan 18, 2010 at 7:36 AM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote: > > On Mon, Jan 18, 2010 at 01:48:55PM +0100, Samuel Ortiz wrote: > >> Hi Cory, > >> > >> I applied this patch, thanks a lot. > >> In the future, I'd like to see the GPIO handling from this patch moved to > >> drivers/gpio. Could you please look at that ? > > Absolutely, thanks for applying it! I'll send out a follow-on patch > as soon as I've got that change. > > > I forgot to add that I also made it build on non ARM patforms. This line: > > set_irq_flags(irq, IRQF_VALID | IRQF_PROBE); > > became: > > #ifdef CONFIG_ARM > > set_irq_flags(irq, IRQF_VALID | IRQF_PROBE); > > #else > > set_irq_probe(irq); > > #endif > > > > Ah, cool, thanks! After the build failure reports from linux-next, I also had to fix a couple more things: 1) htcpld_set_type(): You're not supposed to access irq_desc directly, you should use irq_to_desc() instead 2) Kconfig: we need to depend on I2C=y, to avoid the problematic case of having I2C_CORE=m and HTC_I2CPLD=y Please let me know if you're not ok with those changes. You can grab them from the for-next branch of my kernel.org tree, at git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next Cheers, Samuel. > - Cory -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
