Hi Thadeu, On Tue, 12 Jan 2010 19:36:43 -0200, Thadeu Lima de Souza Cascardo wrote: > dev_dbg outputs dev_name, which is released with device_unregister. This bug > resulted in output like this: > > [ 7860.470713] i2c Xy2�0: adapter [SMBus I801 adapter at 1880] unregistered > > The right output would be: > [ 60.639233] i2c i2c-0: adapter [SMBus I801 adapter at 1880] unregistered I can't reproduce this bug. Do you have a specific memory poisoning option enabled by any chance? And which kernel version are you running exactly? > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> > --- > drivers/i2c/i2c-core.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index 0ac2f90..d5db0f4 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -843,6 +843,9 @@ int i2c_del_adapter(struct i2c_adapter *adap) > adap->dev.parent); > #endif > > + /* device name is gone after device_unregister */ > + dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name); > + > /* clean up the sysfs representation */ > init_completion(&adap->dev_released); > device_unregister(&adap->dev); > @@ -855,8 +858,6 @@ int i2c_del_adapter(struct i2c_adapter *adap) > idr_remove(&i2c_adapter_idr, adap->nr); > mutex_unlock(&core_lock); > > - dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name); > - > /* Clear the device structure in case this adapter is ever going to be > added again */ > memset(&adap->dev, 0, sizeof(adap->dev)); The device structure is embedded in struct i2c_adapter, so its memory can't be reused before the i2c_adapter itself is freed, which can't happen before the end of function i2c_del_adapter(). Until recently, the device name was embedded in the device structure so the code above was fine. But apparently this changed some 9 months ago... -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
