Re: [PATCH] i2c-ali1563: remove sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 10 Jan 2010 15:33:23 +0100, Németh Márton wrote:
> From: Márton Németh <nm127@xxxxxxxxxxx>
> 
> Remove the following sparse warnings (see "make C=1"):
>  * drivers/i2c/busses/i2c-ali1563.c:91:3: warning: do-while statement is not a compound statement
>  * drivers/i2c/busses/i2c-ali1563.c:161:3: warning: do-while statement is not a compound statement
> 
> Signed-off-by: Márton Németh <nm127@xxxxxxxxxxx>
> ---
> --- linux/drivers/i2c/busses/i2c-ali1563.c.orig	2010-01-10 13:40:31.000000000 +0100
> +++ linux/drivers/i2c/busses/i2c-ali1563.c	2010-01-10 13:54:16.000000000 +0100
> @@ -87,9 +87,9 @@
>  	outb_p(inb_p(SMB_HST_CNTL2) | HST_CNTL2_START, SMB_HST_CNTL2);
> 
>  	timeout = ALI1563_MAX_TIMEOUT;
> -	do
> +	do {
>  		msleep(1);
> -	while (((data = inb_p(SMB_HST_STS)) & HST_STS_BUSY) && --timeout);
> +	} while (((data = inb_p(SMB_HST_STS)) & HST_STS_BUSY) && --timeout);
> 
>  	dev_dbg(&a->dev, "Transaction (post): STS=%02x, CNTL1=%02x, "
>  		"CNTL2=%02x, CMD=%02x, ADD=%02x, DAT0=%02x, DAT1=%02x\n",
> @@ -157,9 +157,9 @@
>  	outb_p(inb_p(SMB_HST_CNTL2) | HST_CNTL2_START, SMB_HST_CNTL2);
> 
>  	timeout = ALI1563_MAX_TIMEOUT;
> -	do
> +	do {
>  		msleep(1);
> -	while (!((data = inb_p(SMB_HST_STS)) & HST_STS_DONE) && --timeout);
> +	} while (!((data = inb_p(SMB_HST_STS)) & HST_STS_DONE) && --timeout);
> 
>  	dev_dbg(&a->dev, "Block (post): STS=%02x, CNTL1=%02x, "
>  		"CNTL2=%02x, CMD=%02x, ADD=%02x, DAT0=%02x, DAT1=%02x\n",

Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux