Hi Wen, On Thu, 23 Apr 2009 17:00:56 +0800, Wang, Wen W wrote: > Hi Jean, > > This is a description for the patch: > 1. Patch for I2C controller driver for Intel low power platform "Moorestown". > 2. The driver depends on a GPIO driver for Intel Moorestown platform. > 3. The patch will: > a. Add i2c_mrst.c and i2c_mrst.h to kernel directory "drivers/i2c/busses" Why such a cryptic name? You know, this isn't MS-DOS, names can be longer than 8 characters ;) > b. Add items into kernel files "drivers/i2c/busses/Kconfig" and "drivers/i2c/Makefile". > c. Modify i2c-boardinfo.c to export i2c_register_board_info() function and add code to detect if a device is already in i2c_board_list. This last item should go to a separate patch, so that it can be discussed. It is not clear to me why you would need to export functions nobody else needed to export. It will be easier to review and merge your code if the bus driver itself is in one patch and any required integration changes are in another. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
