Wolfram Sang said the following: > On Thu, Apr 16, 2009 at 11:06:01AM +0200, Michael Lawnick wrote: >> For MPC adapter there is no class assigned as it is done in other >> adapters. This way no new-style client will ever be instantiated. There >> should be at least a default class assignment. > > Please have a loot at 618b26d52843c0f85b8eb143cf2695d7f6fd072d > Therefore, NACK. AFAICS, this patch related to 2.6.26 and i2c code has changed since. In i2c-core.c@i2c_detect there is now a check whether the driver is legacy, if it is the function is left and driver initialization handled in another way. This was not the case when the patch of Wolfgang Grandegger was applied. I still don't think it makes much sense to include code (i2c-mpc.c) that has no function by default - what in fact is the case since last change of i2c-core.c -- Kind Regards, Michael -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
