Ben Dooks wrote:
On Sat, Mar 28, 2009 at 10:36:50PM +0100, Guennadi Liakhovetski wrote:
On Wed, 25 Mar 2009, Wolfram Sang wrote:
Because I hurry to submit this, because merge window is open.
Ok, I waited for this driver, I really did, and I really prefer having one
driver for as many hardware (SoC) variants as possible instead of having
different drivers, and I really hoped its new version will work
out-of-the-box in my setup (pcm037 with a mt9t031 camera). Unfortunately,
it didn't. I've spent more than a full working day trying to get it to
work, but I didn't succeed so far. It works with the on-board rtc, but it
doesn't work with the camera, connected over a flex cable.
Attached to this email is a version of the i2c driver for i.mx31 that I've
been using with my setup for about half a year now. I adjusted it slightly
to accept the same platform data, so, it is really a drop-in replacement
for i2c-imx.c. Of course, you have to adjust or extend the Makefile. I
actually added a new Kconfig entry for this driver, so I could easily
compare them during the tests.
The source of "my" version does look more logical and more clean to me on
quite a few occasions. So, maybe someone could give it a quick spin on
other *mx* SoCs and see if we can use this one instead? You might have to
replace {read,write}w with readb and writeb, so, it might be a good idea
to abstract them into inlines or macros. Otherwise, I think, it might work
for other CPUs straight away.
I just would like to avoid committing a driver and having to spend hours
or days fixing it afterwards when a possibly more mature version exists.
I'm going to hold off pushing my current tree until this/tommorow
evening so that people have some time to get back to me on what is
the best way to proceed.
Hi Ben,
Jean already requested Linus to pull I2C updates, how about imx-i2c?
Should we have this in rc1?
Darius.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
