On 23 Mar 2009 12:01:33 +0100, krzysztof.h1@xxxxxxxxx wrote: > Jean Delvare napisał(a): > > On Sat, 21 Mar 2009 20:29:54 +0100, Krzysztof Helt wrote: > > > + depends on FB_3DFX >> EXPERIMENTAL > > > + select FB_DDC > > > + default y > > > + help > > > + Say Y here if you want DDC/I2C support for your 3dfx Voodoo3. > > > > It might be worth adding a note that the driver itself doesn't yet take > > benefit of the DDC channel. > > IHMO, it does not matter. A separate patch which make use of it is already > ready to post. If this patch is accepted, the second one will be posted. It > is not worth to add a comment then remove it in the next patch. Ah, very well then. I wasn't sure if you had already been working on it or if it was just a plan for the future. If you already have a patch implementing "full support" then I agree with you. > > > (...) > > > + tdfxfb_setup_ddc_bus(>par->chan[0], "VOODOO3-DDC", info->dev); > > > + tdfxfb_setup_i2c_bus(>par->chan[1], "VOODOO3-I2C", info->dev); > > > > Why all-caps names? What about "Voodoo3 DDC" and "Voodoo3 I2C" instead? > > > > Just a choice. One other driver does it this way. I'll change to > the proposed names. The I2C bus names of framebuffer drivers have a rather bad history :( > > Next step is to deprecate i2c-voodoo3. This requires changes to > > drivers/i2c/busses/Kconfig and > > Documentation/feature-removal-schedule.txt. Are you going to do it or > > should I? > > I don't care. First, this patch must be accepted. It will be accepted, don't worry :) I'll prepare the deprecation patch now, should be fairly trivial. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
