Re: [PATCH] I2C: Call request_irq with IRQF_DISABLED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 05, 2009 at 03:54:24PM +0200, Ari Kauppi wrote:
> I have observed some Spurious IRQ's for I2C1 when all kernel hacking options
> (and thus LOCKDEP) are disabled.
> 
> Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help
> but IRQF_DISABLED is needed for proper behaviour.
> 
> Signed-off-by: Ari Kauppi <Ext-Ari.Kauppi@xxxxxxxxx>

This driver should be in sync with mainline, the only missing commit is

commit 3487568e15df6e133f5f55779dec614dbeb68a99
Author: Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx>
Date:   Tue Nov 25 13:03:46 2008 +0200

    i2c: i2c-omap: Fix BUFSTAT_REG reading
    
    The number of bytes to be received is read from wrong
    place with all OMAPs with highspeed I2C support,
    which involves a FIFO and BUFSTAT_REG. It is the 6
    bits starting from the bit 8 in the BUFSTAT_REG
    that indicate this amount of bytes to be read.
    Moreover, only the 6 LSB:s are relevant for the
    TXSTAT field.
    
    Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx>
    Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

That and this one should be going via linux-i2c mainling list. Could you
send Eero's patch and yours to Jean Delvare (i2c maintainer) ? Please
keep linux-omap in the loop.

That said, this makes sense and avoids that we get interrupts while
handling a previous interrupt.

Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux