Re: [PATCH] i2c: Adapter timeout is in jiffies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 22, 2009 at 04:07:05PM +0100, Jean Delvare wrote:
> From: Jean Delvare <khali@xxxxxxxxxxxx>
> Subject: i2c: Adapter timeout is in jiffies
> 
> i2c_adapter.timeout is in jiffies. Fix all drivers which thought
> otherwise. It didn't really matter as long as the value was only used
> inside the driver, but soon i2c-core will use it too so it must have
> the proper unit.
> 
> Note: for the i2c-mpc driver, this fixes a bug in polling mode.
> Timeout would trigger after 1 jiffy, which is most probably not what
> the author wanted.
> 
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Clifford Wolf <clifford@xxxxxxxxxxx>
> Cc: Sean MacLennan <smaclennan@xxxxxxxxxxxx>
> Cc: Stefan Roese <sr@xxxxxxx>
> Cc: Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Cc: Mark A. Greer <mgreer@xxxxxxxxxx>
> Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-ibm_iic.c |    6 +++---
>  drivers/i2c/busses/i2c-iop3xx.c  |    2 +-
>  drivers/i2c/busses/i2c-mpc.c     |    4 ++--
>  drivers/i2c/busses/i2c-mv64xxx.c |    7 +++----
>  drivers/i2c/busses/i2c-pca-isa.c |    2 +-
>  5 files changed, 10 insertions(+), 11 deletions(-)

For the i2c-mv64xxx.c part:

Acked-by: Mark A. Greer <mgreer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux