On Feb 6, 2009, at 8:00 AM, Timur Tabi wrote:
The i2c_wait() function is using wait_event_interruptible_timeout()
to wait for
the I2C controller to signal that it has completed an I2C bus
operation. If
the process that causes the I2C operation terminated abruptly, the
wait will
be interrupted, returning an error. It is better to let the I2C
operation
finished before the process exits.
It is safe to use wait_event_timeout() instead, because the timeout
will allow
the process to exit if the I2C bus hangs. It's also better to allow
the
I2C operation to finish, because unacknowledged I2C operations can
cause the
I2C bus to hang.
Signed-off-by: Timur Tabi <timur@xxxxxxxxxxxxx>
---
A similar change should probably be done to i2c-cpm.c, and maybe all
other
I2C drivers. Not many use wait_event_interruptible_timeout().
drivers/i2c/busses/i2c-mpc.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
applied to next
- k
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
