Hi Roel, On Wed, 04 Feb 2009 17:07:16 +0100, Roel Kluin wrote: > Jean Delvare wrote: > > It seems you have been a bit overzealous. I now get the following > > warning when building the i2c-algo-pcf driver: > > > > drivers/i2c/algos/i2c-algo-pcf.c: In function 'pcf_xfer': > > drivers/i2c/algos/i2c-algo-pcf.c:377: warning: suggest explicit braces to avoid ambiguous 'else' > > drivers/i2c/algos/i2c-algo-pcf.c:387: warning: suggest explicit braces to avoid ambiguous 'else' > > should be fixed now. > > >> @@ -313,24 +299,26 @@ static int pcf_doAddress(struct i2c_algo_pcf_data *adap, > >> unsigned char addr; > >> > >> addr = msg->addr << 1; > >> + > >> if (flags & I2C_M_RD) > >> addr |= 1; > >> if (flags & I2C_M_REV_DIR_ADDR) > >> addr ^= 1; > >> + > >> i2c_outb(adap, addr); > >> > >> return 0; > >> } > > > > Not sure why you want to add blank lines there. > > Ok, removed. > > ------------------>8-----------------8<------------------------- > cleanup whitespace, fix comments and remove the unused STUB_I2C. > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> Applied, thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
