> -----Original Message----- > From: Ed Swierk [mailto:eswierk@xxxxxxxxxxxxxxxxxx] > Sent: Tuesday, January 06, 2009 11:14 PM > To: BARRE Sebastien > Cc: linux-i2c@xxxxxxxxxxxxxxx; David Brownell; Alessandro Zummo; linux- > kernel@xxxxxxxxxxxxxxx; Andrew Morton > Subject: Re: [PATCH] rtc-ds1307: True SMBus compatibility > > On Tue, Jan 6, 2009 at 5:35 AM, BARRE Sebastien <sbarre@xxxxxxxxxx> wrote: > > I've read your patch quicly, I will test it on my board as soon as > possible. > > Thanks. > > > You can delete the next 3 lines, they are not useful: > > > >> + ret = ds1307_read_block_data_once(client, command, length, > currvalues); > >> + if (ret < 0) > >> + return ret; > > Oops! Here is an updated patch with these lines removed, and a minor > formatting fix. > > Signed-off-by: Ed Swierk <eswierk@xxxxxxxxxxxxxxxxxx> > > --Ed I've tested the patch on my geode LX board with a DS1307 device. It works well for me. However I think writing the clock one byte at a time could cause strange behavior when using alarms on device like ds1337. Tested-by: Sébastien Barré <sbarre@xxxxxxxxxx> -- Sébastien Barré Bureau d'étude - Développement SDEL Contrôle Commande D2A - Rue Nungesser et Coli 44860 Saint Aignan de Grand Lieu FRANCE Tél : +33(0)2 40 84 50 88 Fax : +33(0)2 40 84 51 10 ��.n��������+%������w��{.n�����{��-��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
