On Mon, 22 Dec 2008, Jean Delvare wrote: > Hi Guennadi, > > Le Jeudi 18 Décembre 2008 09:40, Guennadi Liakhovetski a écrit : > > From: Guennadi Liakhovetski <lg@xxxxxxx> > > > > This camera is rather similar to MT9M001, but also has a couple of > > enhanced features, like pixel binning. > > I didn't look at the datasheets, but just to make sure you didn't > overlook this possibility: wouldn't it make sense to have a single > driver for both devices? The i2c subsystem architecture makes this > easy. Yes, I thought about this, but at least in the present version that binning / skipping difference does make up a significant part of the driver, so, I preferred to make a separate one. > > Signed-off-by: Guennadi Liakhovetski <lg@xxxxxxx> > > --- > > > > Changes since v1: added > > > > i2c_set_clientdata(client, NULL); > > > > in error path and in remove. > > > > drivers/media/video/Kconfig | 6 + > > drivers/media/video/Makefile | 1 + > > drivers/media/video/mt9t031.c | 733 +++++++++++++++++++++++++++++++++++++++ > > include/media/v4l2-chip-ident.h | 1 + > > 4 files changed, 741 insertions(+), 0 deletions(-) > > create mode 100644 drivers/media/video/mt9t031.c > > (...) > > I took a quick look at the code and it looks fine to me, for the > parts I can comment on. So this is: > > Acked-by: Jean Delvare <khali@xxxxxxxxxxxx> Good, thanks. Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
