On Sun, 14 Dec 2008 16:11:17 -0800, David Brownell wrote: > On Sunday 14 December 2008, Ben Dooks wrote: > > Has anyone reveiwed this patch? Are there any comments, or can this > > be commited at somepoint (even if it is during the next merge window)? > > I was thinking that -EINVAL is almost the least informative > diagnostic code possible, since so many places return it > that it's usually hard to find out *which* invalid parameter > triggered ... > > Is there a less-overloaded code you could return? -EINVAL sounds right to me, all that's really missing is dev_dbg() messages in the drivers to log what the exact problem was. > I have no issue with the patch other than that. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
