On 2/28/2025 12:21 PM, Easwar Hariharan wrote:
On 2/27/2025 3:31 PM, Roman Kisel wrote:
The log statement reports the packet status code as the hypercall
status code which causes confusion when debugging.
Fix the name of the datum being logged.
Signed-off-by: Roman Kisel <romank@xxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/storvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index a8614e54544e..d7ec79536d9a 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device,
STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR;
storvsc_log_ratelimited(device, loglevel,
- "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n",
+ "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x sts 0x%x\n",
I'd suggest using "host" than the opaque "sts", since this is already part of the different
levels of status (scsi, srb...) being printed out. With "host", for e.g. the print would be seen
as the following and clearly point out the offending part of the stack.
hv_storvsc fd1d2cbd-ce7c-535c-966b-eb5f811c95f0: tag#599 cmd 0x28 status: scsi 0x2 srb 0x4 host 0xc0000001
I went with the flow calling this "sts": the rest of the file does that.
Your suggestion is better than that, will implement in the next version.
Appreciate your help very much!
Thanks,
Easwar (he/him)
--
Thank you,
Roman
