On 2/27/2025 4:17 PM, Nuno Das Neves wrote:
On 2/27/2025 9:59 AM, Roman Kisel wrote:
On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
From: Stanislav Kinsburskii <skinsburskii@xxxxxxxxxxxxxxxxxxx>
[...]
- pr_info("Hyper-V: privilege flags low 0x%x, high 0x%x, hints 0x%x, misc 0x%x\n",
- ms_hyperv.features, ms_hyperv.priv_high, ms_hyperv.hints,
+ pr_info("Hyper-V: privilege flags low 0x%x, high 0x%x, ext 0x%x, hints 0x%x, misc 0x%x\n",
+ ms_hyperv.features, ms_hyperv.priv_high,
+ ms_hyperv.ext_features, ms_hyperv.hints,
ms_hyperv.misc_features);
Would using %#x instead of 0x%x be better in your opinion?
It's a reasonable suggestion. I'm not sure if it's worth another
version, if this patch seems good enough to merge as-is.
However if I'm doing another version of this series that still
includes this patch, then I can certainly make the change.
You're right, a suggestion like that shouldn't warrant another version,
agreed! Whether you implement that tweak or not, looks good to me.
Reviewed-by: Roman Kisel <romank@xxxxxxxxxxxxxxxxxxx>
Thanks!
[..]
--
Thank you,
Roman
