On 2/27/2025 9:02 AM, Roman Kisel wrote:
>
>
> On 2/26/2025 3:07 PM, Nuno Das Neves wrote:
>
> [...]
>
>> +
>> +const char *hv_result_to_string(u64 hv_status)
>> +{
>> + switch (hv_result(hv_status)) {
>
> [...]
>
>> + return "HV_STATUS_VTL_ALREADY_ENABLED";
>> + default:
>> + return "Unknown";
>> + };
>> + return "Unknown";
>> +}
>> +EXPORT_SYMBOL_GPL(hv_result_to_string);
>
> Should we remove this and output the hexadecimal error code in ~3 places
> this function is used?
>
> The "Unknown" part would make debugging harder actually when something
> fails. I presume that the mainstream scenarios all work, and it is the
> edge cases that might fail, and these are likelier to produce "Unknown".
>
> Folks who actually debug failed hypercalls rarely have issues with
> looking up the error code, and printing "Unknown" to the log is worse
> than a hexadecimal. Like even the people who wrote the code got nothing
> to say about what is going on.
>
Sorry, I have to disagree with this, a recent commit of mine[1] closed a WSL
issue that was open for over 2 years for, partly, the utter uselessness of
the hex return code of the hypercall.
[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d2138eab8cde61e0e6f62d0713e45202e8457d6d
Thanks,
Easwar (he/him)
