On 11/26/2024 10:03 PM, Saurabh Singh Sengar wrote:
On Mon, Nov 25, 2024 at 12:50:15PM +0000, Naman Jain wrote:
Support for send and receive buffers was added for networking usecases
in UIO devices. There is no known usecase of these buffers for devices
other than HV_NIC. Add a check for HV_NIC in probe function to avoid
memory allocation and GPADL setup which would save 47 MB memory per
device type.
Thanks for the patch. How about rephrasing the commit message like this:
Receive and send buffer allocation was originally introduced to support
DPDK's networking use case. These buffer sizes were further increased to
meet DPDK performance requirements. However, these large buffers are
unnecessary for any other UIO use cases.
Restrict the allocation of receive and send buffers only for HV_NIC device
type, saving 47 MB of memory per device.
Thanks for the review. I'll rephrase it and push it in a new patch after
a few days, considering ongoing merge window.
Regards,
Naman
