There are ~1150 call sites for msecs_to_jiffies() that: - Use a multiplier of 1000, or MSEC_PER_SEC, or - have timeouts that are denominated in seconds, i.e. end in 000 There are yet more sites that use (secs * HZ). Provide secs_to_jiffies() as a new member of the *_to_jiffies() family and convert a few instances as a first user. Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx> --- changelog: v3: - Pickup Reviewed-by tag from Luiz Augusto von Dentz - Add kernel doc comment for secs_to_jiffies() (tglx) - secs_to_jiffies() is defined as a macro rather than a static inline function due to its potential usage in struct initializers, where it wouldn't work per Geert (documentation in changelog requested per tglx) v2: https://lore.kernel.org/r/20241028-open-coded-timeouts-v2-0-c7294bb845a1@xxxxxxxxxxxxxxxxxxx - Add a cover letter - Define secs_to_jiffies(s) as (s * HZ) instead of msecs_to_jiffies(s * MSEC_PER_SEC) (Anna-Maria) v1: https://lore.kernel.org/all/20241022185353.2080021-1-eahariha@xxxxxxxxxxxxxxxxxxx/ - Move secs_to_jiffies in include/linux/jiffies.h - Use secs_to_jiffies in drivers/hv RFC: https://lore.kernel.org/all/20241016223730.531861-1-eahariha@xxxxxxxxxxxxxxxxxxx/ - Convert open coded timeouts (secs * HZ) in drivers/hv to msecs_to_jiffies() --- Easwar Hariharan (2): jiffies: Define secs_to_jiffies() drivers: hv: Convert open-coded timeouts to secs_to_jiffies() drivers/hv/hv_balloon.c | 9 +++++---- drivers/hv/hv_kvp.c | 4 ++-- drivers/hv/hv_snapshot.c | 3 ++- drivers/hv/vmbus_drv.c | 2 +- include/linux/jiffies.h | 12 ++++++++++++ net/bluetooth/hci_event.c | 2 -- 6 files changed, 22 insertions(+), 10 deletions(-) --- base-commit: 81983758430957d9a5cb3333fe324fd70cf63e7e change-id: 20241028-open-coded-timeouts-6dc7cbb6572d Best regards, -- Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
