Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/30/2024 10:31 PM, Shradha Gupta wrote:
Currently the values of WQs for RX and TX queues for MANA devices
are hardcoded to default sizes.
Allow configuring these values for MANA devices as ringparam
configuration(get/set) through ethtool_ops.

Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
Reviewed-by: Long Li <longli@xxxxxxxxxxxxx>
---
  Changes in v2:
  * Removed unnecessary validations in mana_set_ringparam()
  * Fixed codespell error
  * Improved error message to indicate issue with the parameter
---
  drivers/net/ethernet/microsoft/mana/mana_en.c | 20 +++---
  .../ethernet/microsoft/mana/mana_ethtool.c    | 66 +++++++++++++++++++
  include/net/mana/mana.h                       | 21 +++++-
  3 files changed, 96 insertions(+), 11 deletions(-)


From what I understand, we are adding support for "ethtool -G --set-
ring"  command.
Please correct me if I am wrong.

Maybe it would be good to capture the benefit/purpose of this patch in
the commit msg, as in which use-cases/scenarios we are now trying to
support that previously were not supported. The "why?" part basically.



Regards,
Naman Jain




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux