Re: [PATCH] Drivers: hv: vmbus: Add missing check for dma_set_mask in vmbus_device_register()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> child_device_obj->device cannot perform DMA properly if dma_set_mask()
> returns non-zero. …

Another wording suggestion:
  Direct memory access can not be properly performed any more
  after a dma_set_mask() call failed.


See also:
https://elixir.bootlin.com/linux/v6.10-rc6/source/kernel/dma/mapping.c#L804


>      … child_device_obj->device is not initialized here, so use kfree() to
> free child_device_obj->device.

How did you come to the conclusion that meaningful data processing
would still be possible according to such information?


…
> Signed-off-by: Haoxiang Li <make24@xxxxxxxxxxx>

I find it interesting that another personal name is presented here.
I noticed that some patches were published with the name “Ma Ke” previously.
How will requirements be resolved for the Developer's Certificate of Origin?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n398


Would you like to append parentheses to another function name in the summary phrase?

Regards,
Markus





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux