On Tue, Jun 11, 2024 at 09:46:53PM +0200, Borislav Petkov wrote: > On Tue, Jun 11, 2024 at 06:47:05PM +0300, Kirill A. Shutemov wrote: > > Borislav, given this code deduplication effort is not trivial, maybe we > > can do it as a separate patchset on top of this one? > > Sure, as long as it gets done and doesn't get delayed indefinitely by > new and more important features enablement. I will try to deliver it in timely manner. > Usually, we do unifications and cleanups first - then new features but > this kexec pile has been long in the making already... > > > I also wounder if it makes sense to combine ident_map.c and > > set_memory.c. There's some overlap between the two. > > Yeah, we have a bunch of different pagetable manipulating things, all > with their peculiarities and unifying them and having a good set of APIs > which everything else uses, is always a good thing. Will give it a try. > And since we're talking cleanups, there's another thing I've been > looking at critically: CONFIG_X86_5LEVEL. Maybe it is time to get rid of > it and make the 5level stuff unconditional. And get rid of a bunch of > code since both vendors support 5level now... Can do. -- Kiryl Shutsemau / Kirill A. Shutemov
