On Mon, Apr 29, 2024 at 05:29:23PM +0300, Kirill A. Shutemov wrote: > Hm. I considered the sentence to be in imperative mood already. I guess I > don't fully understand what imperative mood is. Will fix. This: https://en.wikipedia.org/wiki/Imperative_mood but basically the sentence is a command. > You are right, I didn't run get_maintainer.pl this time. I never got it > integrated properly into my workflow. How do you use it? Is it part of > 'git send-email' hooks or do you do it manually somehow. So what I do after the whole set is applied, is: git diff HEAD~<NUM>.. | ./scripts/get_maintainer.pl where <NUM> is the number of patches which belong to the series. IOW, you get a full diff of the set and you run that diff through get_maintainer.pl. It'll give you a whole lot of people but you can go through that list and prune it to the people who are really relevant for the set. And then you do git send-email --cc-cmd=cccmd.sh ... and that script simply echoes a "Cc: <name>" one per line. That is, if there are a lot of people to Cc. If there are only 1-3ish or so, you can supply each with the "--cc" option to git-send-email. Anyway, this is what I do. Someone has probably a lot better flow tho. > I don't feel I can trust the script to do The Right Thing™ all the time > to put into my hooks. I expect it to blow up on tree-wide patches for > instance. Yeah, not even going there. :-) HTH. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
