Wed, Apr 24, 2024 at 12:32:54PM CEST, shradhagupta@xxxxxxxxxxxxxxxxxxx wrote: >These patches include adding sysfs attributes for improving >debuggability on MANA devices. > >The first patch consists on max_mtu, min_mtu attributes that are >implemented generically for all devices > >The second patch has mana specific attributes max_num_msix and num_ports 1) you implement only max, min is never implemented, no point introducing it. 2) having driver implement sysfs entry feels *very wrong*, don't do that 3) why DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX and DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN Are not what you want? > >Shradha Gupta (2): > net: Add sysfs atttributes for max_mtu min_mtu > net: mana: Add new device attributes for mana > > Documentation/ABI/testing/sysfs-class-net | 16 ++++++++++ > .../net/ethernet/microsoft/mana/gdma_main.c | 32 +++++++++++++++++++ > net/core/net-sysfs.c | 4 +++ > 3 files changed, 52 insertions(+) > >-- >2.34.1 > >
